linux-kernel - Re: [PATCH v3 2/5] RISC-V: Add kexec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c821aaf141651f5c58c84bb0f294e9b@mailhost.ics.forth.gr>
Date:   Fri, 09 Apr 2021 13:19:28 +0300
From:   Nick Kossifidis <mick@....forth.gr>
To:     Alex Ghiti <alex@...ti.fr>
Cc:     Nick Kossifidis <mick@....forth.gr>,
        linux-riscv@...ts.infradead.org, palmer@...belt.com,
        paul.walmsley@...ive.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/5] RISC-V: Add kexec support

Στις 2021-04-06 21:38, Alex Ghiti έγραψε:
> Le 4/5/21 à 4:57 AM, Nick Kossifidis a écrit :
>> +
>> +/* Reserve a page for the control code buffer */
>> +#define KEXEC_CONTROL_PAGE_SIZE 4096
> 
> PAGE_SIZE instead ?
> 

Yup, I'll change it.

>> +obj-${CONFIG_KEXEC}		+= kexec_relocate.o machine_kexec.o
> 
> Other obj-$() use parenthesis.
> 

ACK

>> +	li	s5, ((1 << PAGE_SHIFT) / RISCV_SZPTR)
> 
> 1 << PAGE_SHIFT = PAGE_SIZE
> 

ACK

>> +#if defined(CONFIG_HOTPLUG_CPU) && (CONFIG_SMP)
> 
> Shouldn't it be defined(CONFIG_SMP) ?
> 

It depends on SMP anyway, I'll remove the second part.