linux-kernel - Re: [PATCH v3 4/5] RISC-V: Add kdump support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75abd98990bfaae51262b72cf7d59831@mailhost.ics.forth.gr>
Date:   Fri, 09 Apr 2021 13:21:48 +0300
From:   Nick Kossifidis <mick@....forth.gr>
To:     Alex Ghiti <alex@...ti.fr>
Cc:     Nick Kossifidis <mick@....forth.gr>,
        linux-riscv@...ts.infradead.org, palmer@...belt.com,
        paul.walmsley@...ive.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/5] RISC-V: Add kdump support

Στις 2021-04-06 21:36, Alex Ghiti έγραψε:
> 
>> +	/* Switch to physical addressing */
>> +	la	s4, 1f
>> +	sub	s4, s4, s3
>> +	csrw	stvec, s4
>> +	csrw	sptbr, zero
> 
> satp is used everywhere instead of sptbr. And maybe you could CSR_****
> naming, like you did in riscv_crash_save_regs and like it's done in
> head.S too.
> 

ACK

>> +		crash_base = memblock_find_in_range(search_start, search_end,
>> +#ifdef CONFIG_64BIT
>> +						    crash_size, SZ_2M);
>> +#else
>> +						    crash_size, SZ_4M);
>> +#endif
> 
> You can use PMD_SIZE here and get rid of #ifdef.
> 
>> +
>> +#ifdef CONFIG_64BIT
>> +		if (!IS_ALIGNED(crash_base, SZ_2M)) {
>> +#else
>> +		if (!IS_ALIGNED(crash_base, SZ_4M)) {
>> +#endif
> 
> Ditto here.
> 

Will do.

Thanks a lot for your review !