linux-kernel - Re: [Outreachy kernel] [PATCH] Staging: Remove line to fix checkpatch error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2104121208530.6734@hadrien>
Date:   Mon, 12 Apr 2021 12:10:54 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     tawahpeggy <tawahpeggy98@...il.com>
cc:     Ian Abbott <abbotti@....co.uk>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        outreachy-kernel@...glegroups.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] Staging: Remove line to fix checkpatch
 error



On Sun, 11 Apr 2021, tawahpeggy wrote:

> remove one empty line.CHECK: Please don't use multiple blank lines

Did something go wrong with the patch generation?  You say that you are
removing one line, but the diff information looks like you are adding a
file.  Normally a patch has only the changed lines and a few lines before
and after.

> Signed-off-by: tawahpeggy <tawahpeggy98@...il.com>

You need to put your real name when contributing to the Linux kernel.

For example, I would put:

Julia Lawall <julia.lawall@...ia.fr>

julia

>
> ---
>  drivers/staging/comedi/comedi_pcmcia.mod.c | 1 -
>  1 file changed, 0 insertion(+), 1 deletion(-)
>  create mode 100644 drivers/staging/comedi/comedi_pcmcia.mod.c
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.mod.c b/drivers/staging/comedi/comedi_pcmcia.mod.c
> index 0904b8765afs96..3984db1a39c8
> --- /dev/null
> +++ b/drivers/staging/comedi/comedi_pcmcia.mod.c
> @@ -0,0 +1,31 @@
> #include <linux/module.h>
> #define INCLUDE_VERMAGIC
> #include <linux/build-salt.h>
> #include <linux/vermagic.h>
> #include <linux/compiler.h>
>
> BUILD_SALT;
>
> MODULE_INFO(vermagic, VERMAGIC_STRING);
> MODULE_INFO(name, KBUILD_MODNAME);
>
> __visible struct module __this_module
> __section(".gnu.linkonce.this_module") = {
> 	.name = KBUILD_MODNAME,
> 	.init = init_module,
> #ifdef CONFIG_MODULE_UNLOAD
> 	.exit = cleanup_module,
> #endif
> 	.arch = MODULE_ARCH_INIT,
> };
>
> #ifdef CONFIG_RETPOLINE
> MODULE_INFO(retpoline, "Y");
> #endif
>
> MODULE_INFO(staging, "Y");
>
> MODULE_INFO(depends, "pcmcia,comedi");
>
> -
> MODULE_INFO(srcversion, "ED971F2E01020DFA2B04486");
> --
> 2.17.1
> h-Hartman <gregkh@...uxfoundation.org>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210411204933.GA3524%40peggy-Lenovo-V130-15IKB.
>