linux-kernel - Re: [PATCH] lightnvm: remove duplicate include in lightnvm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2bd4734-959c-4505-7e1c-ccc04185e4d3@lightnvm.io>
Date:   Tue, 13 Apr 2021 12:55:28 +0200
From:   Matias Bjørling <mb@...htnvm.io>
To:     menglong8.dong@...il.com
Cc:     linux-block@...r.kernel.org, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Zhang Yunkai <zhang.yunkai@....com.cn>
Subject: Re: [PATCH] lightnvm: remove duplicate include in lightnvm.h

On 13/03/2021 12.22, menglong8.dong@...il.com wrote:
> From: Zhang Yunkai <zhang.yunkai@....com.cn>
>
> 'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
> It is also included in the 33th line.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@....com.cn>
> ---
>   include/uapi/linux/lightnvm.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
> index ead2e72e5c88..2745afd9b8fa 100644
> --- a/include/uapi/linux/lightnvm.h
> +++ b/include/uapi/linux/lightnvm.h
> @@ -22,7 +22,6 @@
>   
>   #ifdef __KERNEL__
>   #include <linux/const.h>
> -#include <linux/ioctl.h>
>   #else /* __KERNEL__ */
>   #include <stdio.h>
>   #include <sys/ioctl.h>
Thanks, Yunkai. I've pulled it. Note that I've merged your two patches 
into one.