linux-kernel - Re: [PATCH v4 1/3] kunit: make test->lock irq safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFd5g46sOqqjgwHN0Ca55VWUxx+ZzbTfCuh6Axhy4fgwJhQMGw@mail.gmail.com>
Date:   Tue, 13 Apr 2021 06:38:08 -0700
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     glittao@...il.com
Cc:     Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        KUnit Development <kunit-dev@...glegroups.com>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Marco Elver <elver@...gle.com>,
        Daniel Latypov <dlatypov@...gle.com>
Subject: Re: [PATCH v4 1/3] kunit: make test->lock irq safe

On Tue, Apr 13, 2021 at 3:07 AM <glittao@...il.com> wrote:
>
> From: Vlastimil Babka <vbabka@...e.cz>
>
> The upcoming SLUB kunit test will be calling kunit_find_named_resource() from
> a context with disabled interrupts. That means kunit's test->lock needs to be
> IRQ safe to avoid potential deadlocks and lockdep splats.
>
> This patch therefore changes the test->lock usage to spin_lock_irqsave()
> and spin_unlock_irqrestore().
>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Oliver Glitta <glittao@...il.com>

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>

Thanks!