linux-kernel - Re: [PATCH -next] drm: bridge: fix LONTIUM use of mipi_dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Apr 2021 21:36:39 +0200
From:   Adrien Grassein <adrien.grassein@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Sam Ravnborg <sam@...nborg.org>, Vinod Koul <vkoul@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        stable@...r.kernel.org
Subject: Re: [PATCH -next] drm: bridge: fix LONTIUM use of mipi_dsi_() functions

Reviewed-by: Adren Grassein <adrien.grassein@...il.com>

Le jeu. 15 avr. 2021 à 20:36, Randy Dunlap <rdunlap@...radead.org> a écrit :
>
> The Lontium DRM bridge drivers use mipi_dsi_() function interfaces so
> they need to select DRM_MIPI_DSI to prevent build errors.
>
> ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined!
> ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined!
> ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined!
> ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined!
> ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611uxc.ko] undefined!
> ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined!
> ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined!
> ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined!
> ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined!
> ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/lontium-lt9611.ko] undefined!
> WARNING: modpost: suppressed 5 unresolved symbol warnings because there were too many)
>
> Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge")
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: Vinod Koul <vkoul@...nel.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Cc: Adrien Grassein <adrien.grassein@...il.com>
> Cc: Andrzej Hajda <a.hajda@...sung.com>
> Cc: Neil Armstrong <narmstrong@...libre.com>
> Cc: Robert Foss <robert.foss@...aro.org>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: stable@...r.kernel.org
> ---
>  drivers/gpu/drm/bridge/Kconfig |    3 +++
>  1 file changed, 3 insertions(+)
>
> --- linux-next-20210414.orig/drivers/gpu/drm/bridge/Kconfig
> +++ linux-next-20210414/drivers/gpu/drm/bridge/Kconfig
> @@ -66,6 +66,7 @@ config DRM_LONTIUM_LT8912B
>         depends on OF
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER
> +       select DRM_MIPI_DSI
>         select REGMAP_I2C
>         help
>           Driver for Lontium LT8912B DSI to HDMI bridge
> @@ -81,6 +82,7 @@ config DRM_LONTIUM_LT9611
>         depends on OF
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER
> +       select DRM_MIPI_DSI
>         select REGMAP_I2C
>         help
>           Driver for Lontium LT9611 DSI to HDMI bridge
> @@ -94,6 +96,7 @@ config DRM_LONTIUM_LT9611UXC
>         depends on OF
>         select DRM_PANEL_BRIDGE
>         select DRM_KMS_HELPER
> +       select DRM_MIPI_DSI
>         select REGMAP_I2C
>         help
>           Driver for Lontium LT9611UXC DSI to HDMI bridge