linux-kernel - Re: [PATCH v8 2/4] libperf: Add evsel mmap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YHiV5vqSD3TmUspL@kernel.org>
Date:   Thu, 15 Apr 2021 16:37:10 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>, Rob Herring <robh@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Mark Rutland <mark.rutland@....com>,
        Itaru Kitayama <itaru.kitayama@...il.com>
Subject: Re: [PATCH v8 2/4] libperf: Add evsel mmap support

Em Thu, Apr 15, 2021 at 04:14:31AM +0900, Namhyung Kim escreveu:
> On Thu, Apr 15, 2021 at 3:23 AM Arnaldo Carvalho de Melo
> <acme@...nel.org> wrote:
> >
> > Em Wed, Apr 14, 2021 at 03:02:08PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Thu, Apr 15, 2021 at 01:41:35AM +0900, Namhyung Kim escreveu:
> > > > Hello,
> > > >
> > > > On Thu, Apr 15, 2021 at 1:07 AM Rob Herring <robh@...nel.org> wrote:
> > > > > +void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int thread)
> > > > > +{
> > > > > +       if (FD(evsel, cpu, thread) < 0 || MMAP(evsel, cpu, thread) == NULL)
> > > > > +               return NULL;
> > > >
> > > > I think you should check the cpu and the thread is in
> > > > a valid range.  Currently xyarray__entry() simply accesses
> > > > the content without checking the boundaries.
> > >
> > > So, since xyarray has the bounds, it should check it, i.e. we need to
> > > have a __xyarray__entry() that is what xyarray__entry() does, i.e.
> > > assume the values have been bounds checked, then a new method,
> > > xyarray__entry() that does bounds check, if it fails, return NULL,
> > > otherwise calls __xyarray__entry().
> > >
> > > I see this is frustrating and I should've chimed in earlier, but at
> > > least now this is getting traction, and the end result will be better
> > > not just for the feature you've been dilligently working on,
> > >
> > > Thank you for your persistence,
> >
> > Re-reading, yeah, this can be done in a separate patch, Namhyung, can I
> > have your Reviewed-by? That or an Acked-by?
> 
> Sure, for the series:
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Ok, b4 failed on it, probably some missing Reply to, so I'll apply it by
hand:

[acme@...e perf]$ b4 am -t -s -l --cc-trailers 20210414155412.3697605-1-robh@...nel.org
Looking up https://lore.kernel.org/r/20210414155412.3697605-1-robh%40kernel.org
Grabbing thread from lore.kernel.org/lkml
Analyzing 11 messages in the thread
---
Thread incomplete, attempting to backfill
---
Writing ./v8_20210414_robh_libperf_userspace_counter_access.mbx
  [PATCH v8 1/4] tools/include: Add an initial math64.h
    + Acked-by: Namhyung Kim <namhyung@...nel.org>
    + Acked-by: Jiri Olsa <jolsa@...hat.com> (✓ DKIM/redhat.com)
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
    + Link: https://lore.kernel.org/r/20210414155412.3697605-2-robh@kernel.org
    + Cc: Catalin Marinas <catalin.marinas@....com>
    + Cc: Mark Rutland <mark.rutland@....com>
    + Cc: Itaru Kitayama <itaru.kitayama@...il.com>
    + Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
    + Cc: Will Deacon <will@...nel.org>
    + Cc: Ingo Molnar <mingo@...hat.com>
    + Cc: linux-kernel@...r.kernel.org
  ERROR: missing [2/4]!
  [PATCH v8 3/4] libperf: tests: Add support for verbose printing
    + Acked-by: Jiri Olsa <jolsa@...hat.com> (✓ DKIM/redhat.com)
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
    + Link: https://lore.kernel.org/r/20210414155412.3697605-3-robh@kernel.org
    + Cc: Catalin Marinas <catalin.marinas@....com>
    + Cc: Mark Rutland <mark.rutland@....com>
    + Cc: Itaru Kitayama <itaru.kitayama@...il.com>
    + Cc: Peter Zijlstra <peterz@...radead.org>
    + Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
    + Cc: Namhyung Kim <namhyung@...nel.org>
    + Cc: Will Deacon <will@...nel.org>
    + Cc: Ingo Molnar <mingo@...hat.com>
    + Cc: linux-kernel@...r.kernel.org
  [PATCH v8 4/4] libperf: Add support for user space counter access
    + Acked-by: Jiri Olsa <jolsa@...hat.com> (✓ DKIM/redhat.com)
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
    + Link: https://lore.kernel.org/r/20210414155412.3697605-4-robh@kernel.org
    + Cc: Catalin Marinas <catalin.marinas@....com>
    + Cc: Mark Rutland <mark.rutland@....com>
    + Cc: Itaru Kitayama <itaru.kitayama@...il.com>
    + Cc: Peter Zijlstra <peterz@...radead.org>
    + Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
    + Cc: Namhyung Kim <namhyung@...nel.org>
    + Cc: Will Deacon <will@...nel.org>
    + Cc: Ingo Molnar <mingo@...hat.com>
    + Cc: linux-kernel@...r.kernel.org
---
Total patches: 3
---
WARNING: Thread incomplete!
Cover: ./v8_20210414_robh_libperf_userspace_counter_access.cover
 Link: https://lore.kernel.org/r/20210414155412.3697605-1-robh@kernel.org
 Base: not found
       git am ./v8_20210414_robh_libperf_userspace_counter_access.mbx
[acme@...e perf]$