lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Apr 2021 17:42:29 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jacopo Mondi <jacopo+renesas@...ndi.org>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Kieran Bingham <kieran.bingham@...asonboard.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/7] dt-bindings: media: max9286: Re-indent example

Hi Jacopo,

Thank you for the patch.

On Thu, Apr 15, 2021 at 02:25:56PM +0200, Jacopo Mondi wrote:
> The dt-bindings examples are usually indented with 4 spaces.
> 
> The maxim,max9286 schema has the example indented with only
> 2 spaces, re-indent it.
> 
> Cosmetic change only.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>

Tested by applying and verifying that `git show -b` shows an empty diff.

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  .../bindings/media/i2c/maxim,max9286.yaml     | 214 +++++++++---------
>  1 file changed, 107 insertions(+), 107 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index ee16102fdfe7..0e7162998b77 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -191,140 +191,140 @@ examples:
>      #include <dt-bindings/gpio/gpio.h>
>  
>      i2c@...d8000 {
> -      #address-cells = <1>;
> -      #size-cells = <0>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
>  
> -      reg = <0 0xe66d8000>;
> +        reg = <0 0xe66d8000>;
>  
> -      gmsl-deserializer@2c {
> -        compatible = "maxim,max9286";
> -        reg = <0x2c>;
> -        poc-supply = <&camera_poc_12v>;
> -        enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
> +        gmsl-deserializer@2c {
> +            compatible = "maxim,max9286";
> +            reg = <0x2c>;
> +            poc-supply = <&camera_poc_12v>;
> +            enable-gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
>  
> -        gpio-controller;
> -        #gpio-cells = <2>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
>  
> -        maxim,reverse-channel-microvolt = <170000>;
> +            maxim,reverse-channel-microvolt = <170000>;
>  
> -        ports {
> -          #address-cells = <1>;
> -          #size-cells = <0>;
> +            ports {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
>  
> -          port@0 {
> -            reg = <0>;
> +                port@0 {
> +                    reg = <0>;
>  
> -            max9286_in0: endpoint {
> -              remote-endpoint = <&rdacm20_out0>;
> -            };
> -          };
> -
> -          port@1 {
> -            reg = <1>;
> -
> -            max9286_in1: endpoint {
> -              remote-endpoint = <&rdacm20_out1>;
> -            };
> -          };
> -
> -          port@2 {
> -            reg = <2>;
> -
> -            max9286_in2: endpoint {
> -              remote-endpoint = <&rdacm20_out2>;
> -            };
> -          };
> +                    max9286_in0: endpoint {
> +                        remote-endpoint = <&rdacm20_out0>;
> +                    };
> +                };
>  
> -          port@3 {
> -            reg = <3>;
> +                port@1 {
> +                    reg = <1>;
>  
> -            max9286_in3: endpoint {
> -              remote-endpoint = <&rdacm20_out3>;
> -            };
> -          };
> +                    max9286_in1: endpoint {
> +                        remote-endpoint = <&rdacm20_out1>;
> +                    };
> +                };
>  
> -          port@4 {
> -            reg = <4>;
> +                port@2 {
> +                    reg = <2>;
>  
> -            max9286_out: endpoint {
> -              data-lanes = <1 2 3 4>;
> -              remote-endpoint = <&csi40_in>;
> -            };
> -          };
> -        };
> +                    max9286_in2: endpoint {
> +                        remote-endpoint = <&rdacm20_out2>;
> +                    };
> +                };
>  
> -        i2c-mux {
> -          #address-cells = <1>;
> -          #size-cells = <0>;
> +                port@3 {
> +                    reg = <3>;
>  
> -          i2c@0 {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -            reg = <0>;
> +                    max9286_in3: endpoint {
> +                        remote-endpoint = <&rdacm20_out3>;
> +                    };
> +                };
>  
> -            camera@51 {
> -              compatible = "imi,rdacm20";
> -              reg = <0x51>, <0x61>;
> +                port@4 {
> +                    reg = <4>;
>  
> -              port {
> -                rdacm20_out0: endpoint {
> -                  remote-endpoint = <&max9286_in0>;
> +                    max9286_out: endpoint {
> +                        data-lanes = <1 2 3 4>;
> +                        remote-endpoint = <&csi40_in>;
> +                    };
>                  };
> -              };
> -
>              };
> -          };
> -
> -          i2c@1 {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -            reg = <1>;
>  
> -            camera@52 {
> -              compatible = "imi,rdacm20";
> -              reg = <0x52>, <0x62>;
> +            i2c-mux {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
>  
> -              port {
> -                rdacm20_out1: endpoint {
> -                  remote-endpoint = <&max9286_in1>;
> -                };
> -              };
> -            };
> -          };
> +                i2c@0 {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    reg = <0>;
>  
> -          i2c@2 {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -            reg = <2>;
> +                    camera@51 {
> +                        compatible = "imi,rdacm20";
> +                        reg = <0x51>, <0x61>;
>  
> -            camera@53 {
> -              compatible = "imi,rdacm20";
> -              reg = <0x53>, <0x63>;
> +                        port {
> +                            rdacm20_out0: endpoint {
> +                                remote-endpoint = <&max9286_in0>;
> +                            };
> +                        };
>  
> -              port {
> -                rdacm20_out2: endpoint {
> -                  remote-endpoint = <&max9286_in2>;
> +                    };
>                  };
> -              };
> -            };
> -          };
>  
> -          i2c@3 {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -            reg = <3>;
> +                i2c@1 {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    reg = <1>;
> +
> +                    camera@52 {
> +                        compatible = "imi,rdacm20";
> +                        reg = <0x52>, <0x62>;
> +
> +                        port {
> +                            rdacm20_out1: endpoint {
> +                                remote-endpoint = <&max9286_in1>;
> +                            };
> +                        };
> +                    };
> +                };
>  
> -            camera@54 {
> -              compatible = "imi,rdacm20";
> -              reg = <0x54>, <0x64>;
> +                i2c@2 {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    reg = <2>;
> +
> +                    camera@53 {
> +                        compatible = "imi,rdacm20";
> +                        reg = <0x53>, <0x63>;
> +
> +                        port {
> +                            rdacm20_out2: endpoint {
> +                                remote-endpoint = <&max9286_in2>;
> +                            };
> +                        };
> +                    };
> +                };
>  
> -              port {
> -                rdacm20_out3: endpoint {
> -                  remote-endpoint = <&max9286_in3>;
> +                i2c@3 {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    reg = <3>;
> +
> +                    camera@54 {
> +                        compatible = "imi,rdacm20";
> +                        reg = <0x54>, <0x64>;
> +
> +                        port {
> +                            rdacm20_out3: endpoint {
> +                                remote-endpoint = <&max9286_in3>;
> +                            };
> +                        };
> +                    };
>                  };
> -              };
>              };
> -          };
>          };
> -      };
>      };

-- 
Regards,

Laurent Pinchart

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ