linux-kernel - Re: [PATCH] ALSA: seq: oss: Fix inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hlf9iqznu.wl-tiwai@suse.de>
Date:   Fri, 16 Apr 2021 12:41:57 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: seq: oss: Fix inconsistent indenting

On Fri, 16 Apr 2021 12:00:44 +0200,
Yang Li wrote:
> 
> Kernel test robot throws below warning ->
> 
> smatch warnings:
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn:
> inconsistent indenting
> 
> Fixed the inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  sound/core/seq/oss/seq_oss_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
> index 7b7c925..9a42713 100644
> --- a/sound/core/seq/oss/seq_oss_event.c
> +++ b/sound/core/seq/oss/seq_oss_event.c
> @@ -294,7 +294,7 @@
>  				/* set volume to zero -- note off */
>  			//	type = SNDRV_SEQ_EVENT_NOTEOFF;
>  			//else
> -				if (info->ch[ch].vel)
> +			if (info->ch[ch].vel)
>  				/* sample already started -- volume change */
>  				type = SNDRV_SEQ_EVENT_KEYPRESS;

The line was aligned with the commented if block.
If any, we should rather clean up and re-format the whole block.
(But, OTOH, you shouldn't remove the stuff without understanding
the context.)


thanks,

Takashi