linux-kernel - 回复：[PATCH] ALSA: seq: oss: Fix inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f86e311-dd90-4df8-ae37-09d600e76820.yang.lee@linux.alibaba.com>
Date:   Mon, 19 Apr 2021 18:21:42 +0800
From:   "Yang.Lee" <yang.lee@...ux.alibaba.com>
To:     "Takashi Iwai" <tiwai@...e.de>
Cc:     "tiwai" <tiwai@...e.com>,
        "alsa-devel" <alsa-devel@...a-project.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: 回复：[PATCH] ALSA: seq: oss: Fix inconsistent indenting

Thank you for your suggestion. I will revise and submit it according to the context in the future.

yang
------------------------------------------------------------------
发件人：Takashi Iwai <tiwai@...e.de>
发送时间：2021年4月16日(星期五) 18:41
收件人：Yang Li <yang.lee@...ux.alibaba.com>
抄　送：perex <perex@...ex.cz>; tiwai <tiwai@...e.com>; alsa-devel <alsa-devel@...a-project.org>; linux-kernel <linux-kernel@...r.kernel.org>
主　题：Re: [PATCH] ALSA: seq: oss: Fix inconsistent indenting


On Fri, 16 Apr 2021 12:00:44 +0200,
Yang Li wrote:
> 
> Kernel test robot throws below warning ->
> 
> smatch warnings:
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn:
> inconsistent indenting
> 
> Fixed the inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  sound/core/seq/oss/seq_oss_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
> index 7b7c925..9a42713 100644
> --- a/sound/core/seq/oss/seq_oss_event.c
> +++ b/sound/core/seq/oss/seq_oss_event.c
> @@ -294,7 +294,7 @@
>      /* set volume to zero -- note off */
>     // type = SNDRV_SEQ_EVENT_NOTEOFF;
>     //else
> -    if (info->ch[ch].vel)
> +   if (info->ch[ch].vel)
>      /* sample already started -- volume change */
>      type = SNDRV_SEQ_EVENT_KEYPRESS;

The line was aligned with the commented if block.
If any, we should rather clean up and re-format the whole block.
(But, OTOH, you shouldn't remove the stuff without understanding
the context.)


thanks,

Takashi