linux-kernel - Re: [PATCH] irqchip/xilinx: Expose Kconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zgxys5xn.wl-maz@kernel.org>
Date:   Fri, 16 Apr 2021 14:41:08 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Robert Hancock <robert.hancock@...ian.com>
Cc:     tglx@...utronix.de, michal.simek@...inx.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip/xilinx: Expose Kconfig option

On Fri, 16 Apr 2021 00:32:50 +0100,
Robert Hancock <robert.hancock@...ian.com> wrote:
> 
> Previously the XILINX_INTC config option was hidden and only
> auto-selected on the MicroBlaze platform. However, this IP can also be
> used on other platforms. Allow this option to be user-enabled.
> 
> Signed-off-by: Robert Hancock <robert.hancock@...ian.com>

I don't think this is a good idea. In general, people have no idea
which interrupt controller they need to select. So you either end-up
with a missing interrupt controller, or a bunch you really don't need.

This is essentially a platform constraint, and this should directly be
selected by the platform if you have this IP in your system.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.