linux-kernel - Re: [PATCH 2/4] staging: rtl8188eu: remove constant variable and dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202104180356.LnVJOmXS-lkp@intel.com>
Date:   Sun, 18 Apr 2021 03:57:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Larry Finger <Larry.Finger@...inger.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kbuild-all@...ts.01.org, linux-staging@...ts.linux.dev,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Martin Kaiser <martin@...ser.cx>
Subject: Re: [PATCH 2/4] staging: rtl8188eu: remove constant variable and
 dead code

Hi Martin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Martin-Kaiser/staging-rtl8188eu-change-bLeisurePs-type-to-bool/20210418-020200
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 71d3edc61e29e45b613b841108688d711846f969
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c2b80185c47f9f13ed748eca0df39494668481ee
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Martin-Kaiser/staging-rtl8188eu-change-bLeisurePs-type-to-bool/20210418-020200
        git checkout c2b80185c47f9f13ed748eca0df39494668481ee
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8188eu/os_dep/rtw_android.c:60: warning: Function parameter or member 'cmdstr' not described in 'rtw_android_cmdstr_to_num'
>> drivers/staging/rtl8188eu/os_dep/rtw_android.c:60: warning: expecting prototype for functions(). Prototype was for rtw_android_cmdstr_to_num() instead


vim +60 drivers/staging/rtl8188eu/os_dep/rtw_android.c

5adef66acf7370 Larry Finger         2013-08-21  54  
5adef66acf7370 Larry Finger         2013-08-21  55  /**
c2b80185c47f9f Martin Kaiser        2021-04-17  56   * Local (static) functions
5adef66acf7370 Larry Finger         2013-08-21  57   */
5adef66acf7370 Larry Finger         2013-08-21  58  
5adef66acf7370 Larry Finger         2013-08-21  59  int rtw_android_cmdstr_to_num(char *cmdstr)
5adef66acf7370 Larry Finger         2013-08-21 @60  {
5adef66acf7370 Larry Finger         2013-08-21  61  	int cmd_num;
37ad17a4b48ca7 Yamanappagouda Patil 2016-12-22  62  
5adef66acf7370 Larry Finger         2013-08-21  63  	for (cmd_num = 0; cmd_num < ANDROID_WIFI_CMD_MAX; cmd_num++)
fd078b42096163 Puranjay Mohan       2019-05-21  64  		if (!strncasecmp(cmdstr, android_wifi_cmd_str[cmd_num],
5adef66acf7370 Larry Finger         2013-08-21  65  				 strlen(android_wifi_cmd_str[cmd_num])))
5adef66acf7370 Larry Finger         2013-08-21  66  			break;
5adef66acf7370 Larry Finger         2013-08-21  67  	return cmd_num;
5adef66acf7370 Larry Finger         2013-08-21  68  }
5adef66acf7370 Larry Finger         2013-08-21  69  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (67515 bytes)