linux-kernel - Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77a6e40b57df092d1bd8967305906a210f286111.camel@intel.com>
Date:   Mon, 19 Apr 2021 21:54:13 +0000
From:   "Williams, Dan J" <dan.j.williams@...el.com>
To:     "rostedt@...dmis.org" <rostedt@...dmis.org>
CC:     "fweisbec@...il.com" <fweisbec@...il.com>,
        "jeyu@...nel.org" <jeyu@...nel.org>,
        "mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mingo@...e.hu" <mingo@...e.hu>,
        "chris@...is-wilson.co.uk" <chris@...is-wilson.co.uk>,
        "yuanhan.liu@...ux.intel.com" <yuanhan.liu@...ux.intel.com>,
        "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
Subject: Re: [PATCH][RFC] tracing: Enable tracepoints via module parameters

[ drop Rusty, add Jessica and Emmanuel ]

On Wed, 2013-08-14 at 23:32 -0400, Steven Rostedt wrote:
> On Thu, 15 Aug 2013 11:32:10 +0930
> Rusty Russell <rusty@...tcorp.com.au> wrote:
> 
> > Steven Rostedt <rostedt@...dmis.org> writes:
> > > But the thing about this that bothers me is that there's no way
> > > to say,
> > > "Enable all tracepoints in this module on load". I would like a
> > > way to
> > > do that, but I don't know of a way to do that without modifying
> > > the
> > > module code. Have any ideas? Basically, I would love to have:
> > > 
> > > insmod foo tracepoints=all
> > > 
> > > or something and have all tracepoints enabled.
> > 
> > "without modifying the module code"?  Why?  The code isn't that
> > scary,
> > and this seems useful.
> 
> I'm not afraid of the code, I'm afraid of you ;-) I hear you have
> killer puppies.
> 
> 
> OK, then when I get some time, I may cook something up.
> 
> Thanks,
> 
> -- Steve

Revive an old thread...

Steven, did you ever end up with a solution to the "enable tracing at
module load" problem?

I see some people getting admonished to use ftrace over dev_dbg() [1],
but one of the features that keeps dev_dbg() proliferating is its
generic "$mod_name.dyndbg=" module parameter support for selective
debug enabling at boot / module-load.

It would be useful to be able to do
/sys/kernel/debug/dynamic_debug/control enabling for tracepoints, but
also module::function_name patterns for "got here" style debugging. I'd
be happy to help with this, but wanted to understand where you left
things.

[1]: https://lore.kernel.org/linux-wireless/YHRFy3aq%2FgB7Vde6@kroah.com/