linux-kernel - Re: [PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210421210932.mydyhrz5zdxj47mr@earth.universe>
Date:   Wed, 21 Apr 2021 23:09:32 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Carl Philipp Klemm <philipp@...s.xyz>
Cc:     Tony Lindgren <tony@...mide.com>, zhuguangqing83@...il.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] power: supply: cpcap-battery: fix invalid usage of
 list cursor

Hi,

On Wed, Apr 21, 2021 at 07:19:33PM +0200, Carl Philipp Klemm wrote:
> Tony Lindgren <tony@...mide.com> wrote:
> > * zhuguangqing83@...il.com <zhuguangqing83@...il.com> [210421 14:38]:
> > > From: Guangqing Zhu <zhuguangqing83@...il.com>
> > > 
> > > Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
> > > Empty list or fully traversed list points to list head, which is not
> > > NULL (and before the first element containing real data).
> > > 
> > > Signed-off-by: Guangqing Zhu <zhuguangqing83@...il.com>
> > > ---
> > > v2:
> > >   - Modify commit message and code as suggested by Sebastian.
> > 
> > Thanks looks OK to me. Looks like there's no flag we need to set there when
> > the entry is found, so this should do for the check.
> > 
> > Hmm I wonder if this just might fix the issue where booting with a USB
> > charger connected can hang..
> > 
> > Reviewed-by: Tony Lindgren <tony@...mide.com>
>
> Looks good to me, but dosent appear to solve the bootup bug.
> 
> (this time reply all)
> 
> Reviewed-by: Carl Philipp Klemm <philipp@...s.xyz>
> Tested-by: Carl Philipp Klemm <philipp@...s.xyz>

Thanks, queued.

-- Sebastian

> > >  drivers/power/supply/cpcap-battery.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
> > > index 6d5bcdb9f45d..a3fc0084cda0 100644
> > > --- a/drivers/power/supply/cpcap-battery.c
> > > +++ b/drivers/power/supply/cpcap-battery.c
> > > @@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
> > >  			break;
> > >  	}
> > >  
> > > -	if (!d)
> > > +	if (list_entry_is_head(d, &ddata->irq_list, node))
> > >  		return IRQ_NONE;
> > >  
> > >  	latest = cpcap_battery_latest(ddata);
> > > -- 
> > > 2.17.1
> > > 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)