linux-kernel - Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Apr 2021 19:41:56 -0400
From:   Jeffrey E Altman <jaltman@...istor.com>
To:     "Gustavo A. R. Silva (gustavoars@...nel.org)" <gustavoars@...nel.org>,
        David Howells <dhowells@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     linux-afs@...ts.infradead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

On 3/5/2021 4:19 AM, Gustavo A. R. Silva (gustavoars@...nel.org) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>

This change looks good to me.  Although I would also be happy with a 
fallthrough statement being added instead.

Reviewed-by: Jeffrey Altman <jaltman@...istor.com>


View attachment "jaltman.vcf" of type "text/x-vcard" (272 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)