linux-kernel - [PATCH 1/2] coda: fix reference counting in coda_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210421132012.82354-1-christian.koenig@amd.com>
Date:   Wed, 21 Apr 2021 15:20:11 +0200
From:   "Christian König" 
        <ckoenig.leichtzumerken@...il.com>
To:     linux-kernel@...r.kernel.org, linux-unionfs@...r.kernel.org,
        codalist@...a.cs.cmu.edu, dri-devel@...ts.freedesktop.org
Cc:     jaharkes@...cmu.edu, coda@...cmu.edu, miklos@...redi.hu,
        akpm@...ux-foundation.org, jgg@...pe.ca
Subject: [PATCH 1/2] coda: fix reference counting in coda_file_mmap error path

mmap_region() now calls fput() on the vma->vm_file.

So we need to drop the extra reference on the coda file instead of the
host file.

Signed-off-by: Christian König <christian.koenig@....com>
Fixes: 1527f926fd04 ("mm: mmap: fix fput in error path v2")
CC: stable@...r.kernel.org # 5.11+
---
 fs/coda/file.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/coda/file.c b/fs/coda/file.c
index 128d63df5bfb..ef5ca22bfb3e 100644
--- a/fs/coda/file.c
+++ b/fs/coda/file.c
@@ -175,10 +175,10 @@ coda_file_mmap(struct file *coda_file, struct vm_area_struct *vma)
 	ret = call_mmap(vma->vm_file, vma);
 
 	if (ret) {
-		/* if call_mmap fails, our caller will put coda_file so we
-		 * should drop the reference to the host_file that we got.
+		/* if call_mmap fails, our caller will put host_file so we
+		 * should drop the reference to the coda_file that we got.
 		 */
-		fput(host_file);
+		fput(coda_file);
 		kfree(cvm_ops);
 	} else {
 		/* here we add redirects for the open/close vm_operations */
-- 
2.25.1