linux-kernel - [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210421135021.3360382-1-arnd@kernel.org>
Date:   Wed, 21 Apr 2021 15:50:16 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Coly Li <colyli@...e.de>,
        Kent Overstreet <kent.overstreet@...il.com>,
        Jens Axboe <axboe@...nel.dk>,
        Jianpeng Ma <jianpeng.ma@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Jean Delvare <jdelvare@...e.de>,
        linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES

From: Arnd Bergmann <arnd@...db.de>

Selecting this without CONFIG_BLK_DEV causes a Kconfig warning:

WARNING: unmet direct dependencies detected for LIBNVDIMM
  Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
  Selected by [y]:
  - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]

Add it as another dependency.

Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/md/bcache/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
index 0996e366ad0b..9cb3d8c39fc1 100644
--- a/drivers/md/bcache/Kconfig
+++ b/drivers/md/bcache/Kconfig
@@ -40,6 +40,7 @@ config BCACHE_NVM_PAGES
 	bool "NVDIMM support for bcache (EXPERIMENTAL)"
 	depends on BCACHE
 	depends on PHYS_ADDR_T_64BIT
+	depends on BLKDEV
 	select LIBNVDIMM
 	select DAX
 	help
-- 
2.29.2