[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aa96ed83-47f4-39a7-4b6e-fb17cb4e9f84@infradead.org>
Date: Wed, 21 Apr 2021 07:17:33 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Arnd Bergmann <arnd@...nel.org>, Coly Li <colyli@...e.de>,
Kent Overstreet <kent.overstreet@...il.com>,
Jens Axboe <axboe@...nel.dk>,
Jianpeng Ma <jianpeng.ma@...el.com>
Cc: Arnd Bergmann <arnd@...db.de>, Jean Delvare <jdelvare@...e.de>,
linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES
On 4/21/21 6:50 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> Selecting this without CONFIG_BLK_DEV causes a Kconfig warning:
>
> WARNING: unmet direct dependencies detected for LIBNVDIMM
> Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
> Selected by [y]:
> - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]
>
> Add it as another dependency.
>
> Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> drivers/md/bcache/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
> index 0996e366ad0b..9cb3d8c39fc1 100644
> --- a/drivers/md/bcache/Kconfig
> +++ b/drivers/md/bcache/Kconfig
> @@ -40,6 +40,7 @@ config BCACHE_NVM_PAGES
> bool "NVDIMM support for bcache (EXPERIMENTAL)"
> depends on BCACHE
> depends on PHYS_ADDR_T_64BIT
> + depends on BLKDEV
BLK_DEV
> select LIBNVDIMM
> select DAX
> help
>
tested?
--
~Randy
Powered by blists - more mailing lists