linux-kernel - Re: [PATCH] sched/fair.c: add helper func for util_avg and runnable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YIFjWrAZ6Fw4bFQd@hirez.programming.kicks-ass.net>
Date:   Thu, 22 Apr 2021 13:51:54 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Hui Su <suhui@...u.com>
Cc:     mingo@...hat.com, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/fair.c: add helper func for util_avg and
 runnable_avg calc

On Thu, Apr 22, 2021 at 05:14:16PM +0800, Hui Su wrote:
> add helper func for util_avg and runnable_avg calc when entity
> enqueue and dequeue. No functional change.
> 
> without this change:
> size vmlinux
>    text	   data	    bss	    dec	    hex	filename
> 19889268	6632812	2429160	28951240	1b9c2c8	vmlinux
> size kernel/sched/fair.o
>    text	   data	    bss	    dec	    hex	filename
>   40044	   1569	     96	  41709	   a2ed	kernel/sched/fair.o
> ubuntu@...u_server:~/workspace/linux-stable $
> 
> with this change:
> size vmlinux
>    text	   data	    bss	    dec	    hex	filename
> 19889268	6632812	2429160	28951240	1b9c2c8	vmlinux
> size kernel/sched/fair.o
>    text	   data	    bss	    dec	    hex	filename
>   40044	   1569	     96	  41709	   a2ed	kernel/sched/fair.o
> 
> Signed-off-by: Hui Su <suhui@...u.com>
> ---
>  kernel/sched/fair.c | 48 +++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 40 insertions(+), 8 deletions(-)

So you're increasing line-count and clutter for absolutely no benefit.

Why would we want that?