linux-kernel - Re: [PATCH 2/2] thermal/core: Remove unused EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Apr 2021 17:23:09 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Jonathan Corbet <corbet@....net>, Zhang Rui <rui.zhang@...el.com>,
        Amit Kucheria <amitk@...nel.org>,
        Thara Gopinath <thara.gopinath@...aro.org>,
        Flavio Suligoi <f.suligoi@...m.it>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 2/2] thermal/core: Remove unused EXPORT_SYMBOLS

On 22-04-21, 13:34, Daniel Lezcano wrote:
> The functions exported in the thermal_helpers.c file are only used by
> the governors and those are not compilable as module.
> 
> Remove the EXPORT_SYMBOL as no module code needs them.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  .../driver-api/thermal/sysfs-api.rst          | 28 +------------------
>  drivers/thermal/thermal_helpers.c             |  3 --
>  2 files changed, 1 insertion(+), 30 deletions(-)
> 
> diff --git a/Documentation/driver-api/thermal/sysfs-api.rst b/Documentation/driver-api/thermal/sysfs-api.rst
> index 4b638c14bc16..c35266bbc119 100644
> --- a/Documentation/driver-api/thermal/sysfs-api.rst
> +++ b/Documentation/driver-api/thermal/sysfs-api.rst
> @@ -711,33 +711,7 @@ method, the sys I/F structure will be built like this::
>      |---temp1_input:		37000
>      |---temp1_crit:		100000
>  
> -4. Export Symbol APIs
> -=====================
> -
> -4.1. get_tz_trend
> ------------------
> -
> -This function returns the trend of a thermal zone, i.e the rate of change
> -of temperature of the thermal zone. Ideally, the thermal sensor drivers
> -are supposed to implement the callback. If they don't, the thermal
> -framework calculated the trend by comparing the previous and the current
> -temperature values.
> -
> -4.2. get_thermal_instance
> --------------------------
> -
> -This function returns the thermal_instance corresponding to a given
> -{thermal_zone, cooling_device, trip_point} combination. Returns NULL
> -if such an instance does not exist.
> -
> -4.3. thermal_cdev_update
> -------------------------
> -
> -This function serves as an arbitrator to set the state of a cooling
> -device. It sets the cooling device to the deepest cooling state if
> -possible.
> -
> -5. thermal_emergency_poweroff
> +4. thermal_emergency_poweroff
>  =============================
>  
>  On an event of critical trip temperature crossing. Thermal framework
> diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal/thermal_helpers.c
> index 7f50f412e02a..0ecf2c66aa76 100644
> --- a/drivers/thermal/thermal_helpers.c
> +++ b/drivers/thermal/thermal_helpers.c
> @@ -39,7 +39,6 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip)
>  
>  	return trend;
>  }
> -EXPORT_SYMBOL(get_tz_trend);
>  
>  struct thermal_instance *
>  get_thermal_instance(struct thermal_zone_device *tz,
> @@ -63,7 +62,6 @@ get_thermal_instance(struct thermal_zone_device *tz,
>  
>  	return target_instance;
>  }
> -EXPORT_SYMBOL(get_thermal_instance);
>  
>  /**
>   * thermal_zone_get_temp() - returns the temperature of a thermal zone
> @@ -221,7 +219,6 @@ void thermal_cdev_update(struct thermal_cooling_device *cdev)
>  	trace_cdev_update(cdev, target);
>  	dev_dbg(&cdev->device, "set to state %lu\n", target);
>  }
> -EXPORT_SYMBOL(thermal_cdev_update);
>  
>  /**
>   * thermal_zone_get_slope - return the slope attribute of the thermal zone

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh