linux-kernel - [PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210422132956.1628059-1-arnd@kernel.org>
Date:   Thu, 22 Apr 2021 15:29:48 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Mimi Zohar <zohar@...ux.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Stefan Berger <stefanb@...ux.ibm.com>,
        Nayna Jain <nayna@...ux.ibm.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        John Johansen <john.johansen@...onical.com>,
        Tyler Hicks <tyhicks@...ux.microsoft.com>,
        Bruno Meneguele <bmeneg@...hat.com>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE_MODSIG

From: Arnd Bergmann <arnd@...db.de>

When module support is disabled, CONFIG_MODULE_SIG_HASH cannot
be set either, so the build process fails with an error

certs/Makefile:52: *** Could not determine digest type to use from kernel config.  Stop.

when IMA_APPRAISE_MODSIG is set but modules are not.

Add a Kconfig dependency to prevent this configuration.

Fixes: 0165f4ca223b ("ima: enable signing of modules with build time generated key")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 security/integrity/ima/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
index 12e9250c1bec..2c36144cdd24 100644
--- a/security/integrity/ima/Kconfig
+++ b/security/integrity/ima/Kconfig
@@ -242,6 +242,7 @@ config IMA_APPRAISE_MODSIG
 	bool "Support module-style signatures for appraisal"
 	depends on IMA_APPRAISE
 	depends on INTEGRITY_ASYMMETRIC_KEYS
+	depends on MODULES
 	select PKCS7_MESSAGE_PARSER
 	select MODULE_SIG_FORMAT
 	default n
-- 
2.29.2