linux-kernel - Re: [PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2fd688d8-9f39-5839-2262-fb703d19d4c3@linux.vnet.ibm.com>
Date:   Thu, 22 Apr 2021 13:23:31 -0400
From:   Nayna <nayna@...ux.vnet.ibm.com>
To:     Arnd Bergmann <arnd@...nel.org>, Mimi Zohar <zohar@...ux.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Stefan Berger <stefanb@...ux.ibm.com>,
        Nayna Jain <nayna@...ux.ibm.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Arnd Bergmann <arnd@...db.de>,
        John Johansen <john.johansen@...onical.com>,
        Tyler Hicks <tyhicks@...ux.microsoft.com>,
        Bruno Meneguele <bmeneg@...hat.com>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ima: require CONFIG_MODULES for IMA_APPRAISE_MODSIG


On 4/22/21 9:29 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> When module support is disabled, CONFIG_MODULE_SIG_HASH cannot
> be set either, so the build process fails with an error
>
> certs/Makefile:52: *** Could not determine digest type to use from kernel config.  Stop.
>
> when IMA_APPRAISE_MODSIG is set but modules are not.
>
> Add a Kconfig dependency to prevent this configuration.
>
> Fixes: 0165f4ca223b ("ima: enable signing of modules with build time generated key")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks Arnd !!

This fix solves the config issue, but adds an unnecessary MODULES 
dependency on APPRAISE_MODSIG. APPRAISE_MODSIG can be used for kernel 
image(appended signature) as well as for kernel modules.

I am working on the fix. I am sorry for the delay, I got stuck with some 
urgent issues early this week.

Thanks & Regards,

       - Nayna