linux-kernel - Re: [PATCH] SPI: meson-spifc add missed calls to remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Apr 2021 12:47:35 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Artem Lapkin <email2tema@...il.com>
Cc:     narmstrong@...libre.com, khilman@...libre.com,
        jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
        dri-devel@...ts.freedesktop.org, linux-spi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        christianshewitt@...il.com, art@...das.com, nick@...das.com,
        gouwa@...das.com
Subject: Re: [PATCH] SPI: meson-spifc add missed calls to remove function

On Fri, Apr 23, 2021 at 11:42:47AM +0800, Artem Lapkin wrote:
> Problem: rmmod meson_gx_mmc - not stable without spi_master_suspend call
> and we can get stuck when try unload this module

> +++ b/drivers/spi/spi-meson-spifc.c
> @@ -359,6 +359,7 @@ static int meson_spifc_remove(struct platform_device *pdev)
>  	struct spi_master *master = platform_get_drvdata(pdev);
>  	struct meson_spifc *spifc = spi_master_get_devdata(master);
>  
> +	spi_master_suspend(master);
>  	pm_runtime_get_sync(&pdev->dev);
>  	clk_disable_unprepare(spifc->clk);
>  	pm_runtime_disable(&pdev->dev);

I would expect the driver to unregister the controller at the start of
the remove function, suspend doesn't really make sense here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)