linux-kernel - Re: [PATCH] nvmem: qfprom: minor nit fixes, no functional change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73945e7037ab61eb34a2a1af05aa3eef75c8f836.camel@perches.com>
Date:   Fri, 23 Apr 2021 08:13:53 -0700
From:   Joe Perches <joe@...ches.com>
To:     Rajendra Nayak <rnayak@...eaurora.org>,
        srinivas.kandagatla@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        dianders@...omium.org, rbokka@...eaurora.org
Subject: Re: [PATCH] nvmem: qfprom: minor nit fixes, no functional change

On Fri, 2021-04-23 at 12:35 +0530, Rajendra Nayak wrote:
> Fix a missed newline, and update a comment which is stale
> after the merge of '5a1bea2a: nvmem: qfprom: Add support for fuse
> blowing on sc7280'
> No other functional change in this patch.
[]
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
[]
> @@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
>  	}
> 
>  	/*
> -	 * Hardware requires 1.8V min for fuse blowing; this may be
> +	 * Hardware requires a min voltage for fuse blowing; this may be
>  	 * a rail shared do don't specify a max--regulator constraints

   	                 so don't?

>  	 * will handle.
>  	 */

but the comment doesn't make much overall sense to me.