lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202104241919.dtjYvDQq-lkp@intel.com>
Date:   Sat, 24 Apr 2021 19:29:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        Matthieu Baerts <matthieu.baerts@...sares.net>
Subject: net/bridge/br_multicast.c:1430:13: warning: stack frame size of 1072
 bytes in function '__br_multicast_send_query'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8db5efb83fa99e81c3f8dee92a6589b251f117f3
commit: b142083b585c2c03af24cca4d274f797796a4064 mptcp: MPTCP_KUNIT_TESTS should depend on MPTCP instead of selecting it
date:   6 months ago
config: powerpc64-randconfig-r036-20210424 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 3d1aecbd285709f58168b3ad65c06da4b42132a9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b142083b585c2c03af24cca4d274f797796a4064
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout b142083b585c2c03af24cca4d274f797796a4064
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:39:1: note: expanded from here
   __do_insb
   ^
   arch/powerpc/include/asm/io.h:541:56: note: expanded from macro '__do_insb'
   #define __do_insb(p, b, n)      readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
                                          ~~~~~~~~~~~~~~~~~~~~~^
   In file included from net/bridge/br_multicast.c:10:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:41:1: note: expanded from here
   __do_insw
   ^
   arch/powerpc/include/asm/io.h:542:56: note: expanded from macro '__do_insw'
   #define __do_insw(p, b, n)      readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
                                          ~~~~~~~~~~~~~~~~~~~~~^
   In file included from net/bridge/br_multicast.c:10:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:43:1: note: expanded from here
   __do_insl
   ^
   arch/powerpc/include/asm/io.h:543:56: note: expanded from macro '__do_insl'
   #define __do_insl(p, b, n)      readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
                                          ~~~~~~~~~~~~~~~~~~~~~^
   In file included from net/bridge/br_multicast.c:10:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:45:1: note: expanded from here
   __do_outsb
   ^
   arch/powerpc/include/asm/io.h:544:58: note: expanded from macro '__do_outsb'
   #define __do_outsb(p, b, n)     writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
   In file included from net/bridge/br_multicast.c:10:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:47:1: note: expanded from here
   __do_outsw
   ^
   arch/powerpc/include/asm/io.h:545:58: note: expanded from macro '__do_outsw'
   #define __do_outsw(p, b, n)     writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
   In file included from net/bridge/br_multicast.c:10:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/powerpc/include/asm/io.h:604:
   arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
   DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/powerpc/include/asm/io.h:601:3: note: expanded from macro 'DEF_PCI_AC_NORET'
                   __do_##name al;                                 \
                   ^~~~~~~~~~~~~~
   <scratch space>:49:1: note: expanded from here
   __do_outsl
   ^
   arch/powerpc/include/asm/io.h:546:58: note: expanded from macro '__do_outsl'
   #define __do_outsl(p, b, n)     writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
                                           ~~~~~~~~~~~~~~~~~~~~~^
>> net/bridge/br_multicast.c:1430:13: warning: stack frame size of 1072 bytes in function '__br_multicast_send_query' [-Wframe-larger-than=]
   static void __br_multicast_send_query(struct net_bridge *br,
               ^
>> net/bridge/br_multicast.c:2243:12: warning: stack frame size of 1296 bytes in function 'br_ip4_multicast_igmp3_report' [-Wframe-larger-than=]
   static int br_ip4_multicast_igmp3_report(struct net_bridge *br,
              ^
   8 warnings generated.


vim +/__br_multicast_send_query +1430 net/bridge/br_multicast.c

dc4eb53a996a78 Linus Lüssing       2014-06-07  1429  
8ef2a9a5985499 YOSHIFUJI Hideaki   2010-04-18 @1430  static void __br_multicast_send_query(struct net_bridge *br,
8ef2a9a5985499 YOSHIFUJI Hideaki   2010-04-18  1431  				      struct net_bridge_port *port,
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1432  				      struct net_bridge_port_group *pg,
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1433  				      struct br_ip *ip_dst,
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1434  				      struct br_ip *group,
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1435  				      bool with_srcs,
42c11ccfe844c1 Nikolay Aleksandrov 2020-09-07  1436  				      u8 sflag,
42c11ccfe844c1 Nikolay Aleksandrov 2020-09-07  1437  				      bool *need_rexmit)
eb1d16414339a6 Herbert Xu          2010-02-27  1438  {
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1439  	bool over_lmqt = !!sflag;
eb1d16414339a6 Herbert Xu          2010-02-27  1440  	struct sk_buff *skb;
1080ab95e3c7bd Nikolay Aleksandrov 2016-06-28  1441  	u8 igmp_type;
eb1d16414339a6 Herbert Xu          2010-02-27  1442  
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1443  again_under_lmqt:
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1444  	skb = br_multicast_alloc_query(br, pg, ip_dst, group, with_srcs,
42c11ccfe844c1 Nikolay Aleksandrov 2020-09-07  1445  				       over_lmqt, sflag, &igmp_type,
42c11ccfe844c1 Nikolay Aleksandrov 2020-09-07  1446  				       need_rexmit);
eb1d16414339a6 Herbert Xu          2010-02-27  1447  	if (!skb)
8ef2a9a5985499 YOSHIFUJI Hideaki   2010-04-18  1448  		return;
eb1d16414339a6 Herbert Xu          2010-02-27  1449  
eb1d16414339a6 Herbert Xu          2010-02-27  1450  	if (port) {
eb1d16414339a6 Herbert Xu          2010-02-27  1451  		skb->dev = port->dev;
a65056ecf4b48b Nikolay Aleksandrov 2016-07-06  1452  		br_multicast_count(br, port, skb, igmp_type,
1080ab95e3c7bd Nikolay Aleksandrov 2016-06-28  1453  				   BR_MCAST_DIR_TX);
29a26a56803855 Eric W. Biederman   2015-09-15  1454  		NF_HOOK(NFPROTO_BRIDGE, NF_BR_LOCAL_OUT,
29a26a56803855 Eric W. Biederman   2015-09-15  1455  			dev_net(port->dev), NULL, skb, NULL, skb->dev,
f0b4eeced518c6 Linus Lüssing       2014-11-17  1456  			br_dev_queue_push_xmit);
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1457  
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1458  		if (over_lmqt && with_srcs && sflag) {
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1459  			over_lmqt = false;
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1460  			goto again_under_lmqt;
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1461  		}
dc4eb53a996a78 Linus Lüssing       2014-06-07  1462  	} else {
438ef2d027eb32 Nikolay Aleksandrov 2020-09-07  1463  		br_multicast_select_own_querier(br, group, skb);
a65056ecf4b48b Nikolay Aleksandrov 2016-07-06  1464  		br_multicast_count(br, port, skb, igmp_type,
1080ab95e3c7bd Nikolay Aleksandrov 2016-06-28  1465  				   BR_MCAST_DIR_RX);
eb1d16414339a6 Herbert Xu          2010-02-27  1466  		netif_rx(skb);
8ef2a9a5985499 YOSHIFUJI Hideaki   2010-04-18  1467  	}
dc4eb53a996a78 Linus Lüssing       2014-06-07  1468  }
8ef2a9a5985499 YOSHIFUJI Hideaki   2010-04-18  1469  

:::::: The code at line 1430 was first introduced by commit
:::::: 8ef2a9a59854994bace13b5c4f7edc2c8d4d124e bridge br_multicast: Make functions less ipv4 dependent.

:::::: TO: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
:::::: CC: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (26771 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ