linux-kernel - Re: [PATCH v2] pwm: Introduce single-PWM of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210424113204.besr7gye2htzkbkr@pengutronix.de>
Date:   Sat, 24 Apr 2021 13:32:04 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Lee Jones <lee.jones@...aro.org>, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pwm: Introduce single-PWM of_xlate function

Hello,

On Fri, Apr 23, 2021 at 04:33:04PM -0500, Bjorn Andersson wrote:
> The existing pxa driver and the upcoming addition of PWM support in the
> TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and
> thereby a need for a of_xlate function with the period as its single
> argument.
> 
> Introduce a common helper function in the core that can be used as
> of_xlate by such drivers and migrate the pxa driver to use this.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>

I'm OK with the idea as such. I'd like to see the semantic expanded a
bit however such that the function can parse

	pwms = <&mypwm 50000>;

and also

	pwms = <&mypwm 500000 PWM_POLARITY_INVERTED>;

. You suggetion only covers the former.

See
https://lore.kernel.org/r/20210315111124.2475274-2-u.kleine-koenig@pengutronix.de
for my first attempt to unify of_pwm_xlate_with_flags and
of_pwm_simple_xlate accordingly.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)