linux-kernel - Re: [PATCH v10 clocksource 1/7] clocksource: Provide module parameters to inject delays in watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210426182433.GD975577@paulmck-ThinkPad-P17-Gen-1>
Date:   Mon, 26 Apr 2021 11:24:33 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        john.stultz@...aro.org, sboyd@...nel.org, corbet@....net,
        Mark.Rutland@....com, maz@...nel.org, kernel-team@...com,
        neeraju@...eaurora.org, feng.tang@...el.com,
        zhengjun.xing@...el.com, Chris Mason <clm@...com>
Subject: Re: [PATCH v10 clocksource 1/7] clocksource: Provide module
 parameters to inject delays in watchdog

On Mon, Apr 26, 2021 at 10:56:27AM -0700, Andi Kleen wrote:
> > ------------------------------------------------------------------------
> > 
> > - module parameters
> > 
> >   If the scope of the fault injection capability is limited to a
> >   single kernel module, it is better to provide module parameters to
> >   configure the fault attributes.
> > 
> > ------------------------------------------------------------------------
> > 
> > And in this case, the fault injection capability is in fact limited to
> > kernel/clocksource.c.
> 
> 
> I disagree with this recommendation because it prevents fuzzer coverage.
> 
> Much better to have an uniform interface that can be automatically
> explored.

The permissions for these module parameters is 0644, so there is no
reason why the fuzzers cannot use them via sysfs.

							Thanx, Paul