linux-kernel - Re: [PATCH v1 2/3] scsi: ufs: Cancel rpm_dev_flush_recheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f281cc9eea50cd05b7fe3fd6ddaf7474@codeaurora.org>
Date:   Mon, 26 Apr 2021 11:33:23 +0800
From:   Can Guo <cang@...eaurora.org>
To:     daejun7.park@...sung.com
Cc:     asutoshd@...eaurora.org, ziqichen@...eaurora.org,
        nguyenb@...eaurora.org, hongwus@...eaurora.org,
        linux-scsi@...r.kernel.org, kernel-team@...roid.com,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Stanley Chu <stanley.chu@...iatek.com>,
        Bean Huo <beanhuo@...ron.com>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/3] scsi: ufs: Cancel rpm_dev_flush_recheck_work
 during system suspend

On 2021-04-26 11:17, Daejun Park wrote:
> Hi Can Guo,
> 
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index 7ab6b12..090b654 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -9058,11 +9058,12 @@ int ufshcd_system_suspend(struct ufs_hba *hba)
>>         if (!hba->is_powered)
>>                 return 0;
>> 
>> +        cancel_delayed_work_sync(&hba->rpm_dev_flush_recheck_work);
>> +
>>         if ((ufs_get_pm_lvl_to_dev_pwr_mode(hba->spm_lvl) ==
>>              hba->curr_dev_pwr_mode) &&
>>             (ufs_get_pm_lvl_to_link_pwr_state(hba->spm_lvl) ==
>> -             hba->uic_link_state) &&
>> -             !hba->dev_info.b_rpm_dev_flush_capable)
> I think it should not be removed.
> It prevents power drain when runtime suspend and system suspend have 
> same
> power mode.
> 

I will add it back in next ver.

Thanks,
Can Guo

> Thanks,
> Daejun