linux-kernel - Re: [PATCH 141/190] Revert "libertas: add checks for the return value of sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIhNP1RvJzjnLa6e@kroah.com>
Date:   Tue, 27 Apr 2021 19:43:27 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Kangjie Lu <kjlu@....edu>, Kalle Valo <kvalo@...eaurora.org>
Subject: Re: [PATCH 141/190] Revert "libertas: add checks for the return
 value of sysfs_create_group"

On Wed, Apr 21, 2021 at 03:00:16PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 434256833d8eb988cb7f3b8a41699e2fe48d9332.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Kangjie Lu <kjlu@....edu>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/net/wireless/marvell/libertas/mesh.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c
> index f5b78257d551..c611e6668b21 100644
> --- a/drivers/net/wireless/marvell/libertas/mesh.c
> +++ b/drivers/net/wireless/marvell/libertas/mesh.c
> @@ -805,12 +805,7 @@ static void lbs_persist_config_init(struct net_device *dev)
>  {
>  	int ret;
>  	ret = sysfs_create_group(&(dev->dev.kobj), &boot_opts_group);
> -	if (ret)
> -		pr_err("failed to create boot_opts_group.\n");
> -
>  	ret = sysfs_create_group(&(dev->dev.kobj), &mesh_ie_group);
> -	if (ret)
> -		pr_err("failed to create mesh_ie_group.\n");
>  }
>  
>  static void lbs_persist_config_remove(struct net_device *dev)
> -- 
> 2.31.1
> 

The original change here is incorrect, the error needs to be propagated
back to the caller AND if the second group call fails, the first needs
to be removed.  There are much better ways to solve this, the driver
should NOT be calling sysfs_create_group() on its own as it is racing
userspace and loosing.  I will keep this revert and fix it up properly
in a follow-on patch.

thanks,

greg k-h