linux-kernel - Re: [PATCH 028/190] Revert "RDMA/rvt: Fix potential memory leak caused by rvt_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIgeGqV7cV8YpNmQ@kroah.com>
Date:   Tue, 27 Apr 2021 16:22:18 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     linux-kernel@...r.kernel.org, Aditya Pakki <pakki001@....edu>,
        Dennis Dalessandro <dennis.dalessandro@...el.com>
Subject: Re: [PATCH 028/190] Revert "RDMA/rvt: Fix potential memory leak
 caused by rvt_alloc_rq"

On Wed, Apr 21, 2021 at 11:11:05AM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 21, 2021 at 02:58:23PM +0200, Greg Kroah-Hartman wrote:
> > This reverts commit 90a239ee25fa3a483facec3de7c144361a3d3a51.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> > 
> > Cc: https
> > Cc: Aditya Pakki <pakki001@....edu>
> > Cc: Dennis Dalessandro <dennis.dalessandro@...el.com>
> > Cc: Jason Gunthorpe <jgg@...lanox.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  drivers/infiniband/sw/rdmavt/qp.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> While I don't see anything obviously wrong here it is tricky enough
> that I would revert it unless Dennis says otherwise.

Thanks for the review, now dropped.

greg k-h