linux-kernel - Re: [PATCH 044/190] Revert "RDMA/pvrdma: Fix missing pci disable in pvrdma_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIgexw4zOuoNKPB5@kroah.com>
Date:   Tue, 27 Apr 2021 16:25:11 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Roland Dreier <roland@...nel.org>
Cc:     jgg@...lanox.com, linux-kernel@...r.kernel.org, wu000273@....edu
Subject: Re: [PATCH 044/190] Revert "RDMA/pvrdma: Fix missing pci disable in
 pvrdma_pci_probe()"

On Wed, Apr 21, 2021 at 12:25:17PM -0700, Roland Dreier wrote:
> This is a really weird one because the patch actually looks correct
> and the revert looks wrong??
> 
> 	ret = pci_enable_device(pdev);
> 
> [...dbg statements...]
> 
> 	if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) ||
> 	    !(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) {
> 		dev_err(&pdev->dev, "PCI BAR region not MMIO\n");
> 		ret = -ENOMEM;
> 		goto err_disable_pdev;
> 	}
> 
>  - R.

git revert sometimes does odd things :)

I'll go drop this from the tree, thanks.

greg k-h