linux-kernel - Re: [PATCH 037/190] Revert "RDMA/core: Fix several reference count leaks."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIgfbZDo9eQ2tKvc@kroah.com>
Date:   Tue, 27 Apr 2021 16:27:57 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     linux-kernel@...r.kernel.org, Qiushi Wu <wu000273@....edu>
Subject: Re: [PATCH 037/190] Revert "RDMA/core: Fix several reference count
 leaks."

On Wed, Apr 21, 2021 at 11:14:44AM -0300, Jason Gunthorpe wrote:
> On Wed, Apr 21, 2021 at 02:58:32PM +0200, Greg Kroah-Hartman wrote:
> > This reverts commit 0b8e125e213204508e1b3c4bdfe69713280b7abd.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> > 
> > Cc: https
> > Cc: Qiushi Wu <wu000273@....edu>
> > Cc: Jason Gunthorpe <jgg@...lanox.com>
> > Cc: Jason Gunthorpe <jgg@...lanox.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  drivers/infiniband/core/sysfs.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> The original commit is certainly moving things closer to being correct
> but I'm concerned the entire area is still not bug free, it will take
> me some time to check the whole code. Reverting seems reasonable for
> now

I just re-reviewed it, and it looks like the original commit is ok, so I
will drop this.

But ugh, this is horrid code, you should NOT be dealing with "raw"
kobjects here at all, just to try to make a subdirectory tree.  That
causes a total mess as this function shows and probably should be
cleaned up sometime as obviously userspace tools are not properly seeing
the objects you are creating here (hint, you can not put a kobject below
a 'struct device' in the device tree and have udev and others see it
properly...)

But that's a topic for a later time, dropping this now.

greg k-h