linux-kernel - Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKvL0tT=NG6nu1uuzzF_2ce2RNTJxR5iz4VmfTq3iTz2g@mail.gmail.com>
Date:   Wed, 28 Apr 2021 18:45:03 -0500
From:   Rob Herring <robh@...nel.org>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>
Subject: Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property

On Wed, Apr 28, 2021 at 5:42 PM Thomas Bogendoerfer
<tsbogend@...ha.franken.de> wrote:
>
> On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote:
> > On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote:
> > > Interrupts property is required, so add it.
> > >
> > > Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > > ---
> > >  .../bindings/interrupt-controller/idt,32434-pic.yaml          | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: interrupt-controller@...0400: 'oneOf' conditional failed, one must be fixed:
> >       'interrupts' is a required property
> >       'interrupts-extended' is a required property
> >       From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml
>
> now I'm confused... is this a problem of your test ? make dt_binding_check
> was ok with that change...

You and me both. I'll look into it when I apply.

Rob