linux-kernel - [PATCH] nfp: flower: Remove redundant assignment to mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1619604330-122462-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Date:   Wed, 28 Apr 2021 18:05:30 +0800
From:   Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
To:     simon.horman@...ronome.com
Cc:     kuba@...nel.org, davem@...emloft.net, oss-drivers@...ronome.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Subject: [PATCH] nfp: flower: Remove redundant assignment to mask

The value stored to mask in the calculations this patch removes is
not used, so the calculation and the assignment can be removed.

Cleans up the following clang-analyzer warning:

drivers/net/ethernet/netronome/nfp/flower/offload.c:1230:3: warning:
Value stored to 'mask' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
---
 drivers/net/ethernet/netronome/nfp/flower/offload.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c
index e95969c..86e734a 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/offload.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c
@@ -1227,7 +1227,6 @@ int nfp_flower_merge_offloaded_flows(struct nfp_app *app,
 				return -EOPNOTSUPP;
 			}
 		ext += size;
-		mask += size;
 	}
 
 	if ((priv->flower_ext_feats & NFP_FL_FEATS_VLAN_QINQ)) {
-- 
1.8.3.1