linux-kernel - Re: [PATCH v4 1/2] gpio: Add support for IDT 79RC3243x GPIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Apr 2021 14:07:10 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Michael Walle <michael@...le.cc>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] gpio: Add support for IDT 79RC3243x GPIO controller

On Wed, Apr 28, 2021 at 1:51 AM Michael Walle <michael@...le.cc> wrote:
> Am 2021-04-26 12:29, schrieb Andy Shevchenko:
> > On Mon, Apr 26, 2021 at 12:55 PM Thomas Bogendoerfer
> > <tsbogend@...ha.franken.de> wrote:
> >
> > 2) there is gpio-regmap generic code, that may be worth
> > considering.
>
> This driver uses memory mapped registers. While that is
> also possible with gpio-regmap, there is one drawback:
> it assumes gpiochip->can_sleep = true for now, see [1].
> Unfortunately, there is no easy way to ask the regmap
> if its mmio/fastio.

I don't see how it is an impediment.
Prerequisite patch?

> [1]
> https://elixir.bootlin.com/linux/v5.12/source/drivers/gpio/gpio-regmap.c#L257



-- 
With Best Regards,
Andy Shevchenko