linux-kernel - Re: [PATCH v5 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210429164010.GA31397@lpieralisi>
Date:   Thu, 29 Apr 2021 17:40:11 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Greentime Hu <greentime.hu@...ive.com>, paul.walmsley@...ive.com,
        hes@...ive.com, erik.danie@...ive.com, zong.li@...ive.com,
        bhelgaas@...gle.com, robh+dt@...nel.org, aou@...s.berkeley.edu,
        mturquette@...libre.com, sboyd@...nel.org, p.zabel@...gutronix.de,
        alex.dewar90@...il.com, khilman@...libre.com,
        hayashi.kunihiko@...ionext.com, vidyas@...dia.com,
        jh80.chung@...sung.com, linux-pci@...r.kernel.org,
        devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v5 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller
 driver

On Thu, Apr 29, 2021 at 10:15:22AM -0500, Bjorn Helgaas wrote:
> On Thu, Apr 29, 2021 at 03:59:54PM +0100, Lorenzo Pieralisi wrote:
> > On Wed, Apr 28, 2021 at 02:47:13PM -0500, Bjorn Helgaas wrote:
> > > On Tue, Apr 06, 2021 at 05:26:33PM +0800, Greentime Hu wrote:
> > > > From: Paul Walmsley <paul.walmsley@...ive.com>
> > > > 
> > > > Add driver for the SiFive FU740 PCIe host controller.
> > > > This controller is based on the DesignWare PCIe core.
> > > > 
> > > > Signed-off-by: Paul Walmsley <paul.walmsley@...ive.com>
> > > > Co-developed-by: Henry Styles <hes@...ive.com>
> > > > Signed-off-by: Henry Styles <hes@...ive.com>
> > > > Co-developed-by: Erik Danie <erik.danie@...ive.com>
> > > > Signed-off-by: Erik Danie <erik.danie@...ive.com>
> > > > Co-developed-by: Greentime Hu <greentime.hu@...ive.com>
> > > > Signed-off-by: Greentime Hu <greentime.hu@...ive.com>
> > > 
> > > Tripped over these errors while build testing with the .config below.
> > 
> > Sorry about that - the kbot did not managed to test it. Is it a
> > randconfig ? I think we should ask the kbuild bot guys to add it,
> > I think it can be done on a per-repo basis.
> 
> I don't know enough about the bot.  The lkp@...el.com reports I get
> include allyesconfig for x86_64; not sure why that wouldn't catch
> this.
> 
> > Waiting for a fix asap - I can move/rebase some commits if the fix
> > takes time.
> 
> If it's feasible you could just move the FU740 stuff to a different
> branch so we can be sure to include the other dwc stuff.  Same for
> brcmstb.
> 
> Oh, and Colin just posted a NULL pointer check that could be squashed
> into the new mediatek-gen3 driver.

All done. Updated pci/dwc, pci/brcmstb and pci/mediatek, parked the
changes requiring a fix-up in separate branches, will push them out
when fixed.

Thanks,
Lorenzo