linux-kernel - Re: [PATCH 052/190] Revert "media: media/saa7146: fix incorrect assertion in saa7146_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210429200803.GE31692@amd>
Date:   Thu, 29 Apr 2021 22:08:03 +0200
From:   Pavel Machek <pavel@....cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Aditya Pakki <pakki001@....edu>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH 052/190] Revert "media: media/saa7146: fix incorrect
 assertion in saa7146_buffer_finish"

Hi!

> Cc: Aditya Pakki <pakki001@....edu>
> Cc: Hans Verkuil <hverkuil-cisco@...all.nl>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/media/common/saa7146/saa7146_fops.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/common/saa7146/saa7146_fops.c b/drivers/media/common/saa7146/saa7146_fops.c
> index baf5772c52a9..c256146fd3b6 100644
> --- a/drivers/media/common/saa7146/saa7146_fops.c
> +++ b/drivers/media/common/saa7146/saa7146_fops.c
> @@ -95,6 +95,8 @@ void saa7146_buffer_finish(struct saa7146_dev *dev,
>  	DEB_EE("dev:%p, dmaq:%p, state:%d\n", dev, q, state);
>  	DEB_EE("q->curr:%p\n", q->curr);
>  
> +	BUG_ON(!q->curr);
> +
>  	/* finish current buffer */
>  	if (NULL == q->curr) {
>  		DEB_D("aiii. no current buffer\n");

The code is obviously crazy _after_ the revert, so I'd suggest not
reverting it.

But whether this code has any security problems is quite hard to
decide, it was not written with readability in mind :-(.

								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)