linux-kernel - Re: [PATCH 056/190] Revert "media: davinci/vpfe_capture.c: Avoid BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 22:14:14 +0200
From:   Pavel Machek <pavel@....cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Aditya Pakki <pakki001@....edu>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH 056/190] Revert "media: davinci/vpfe_capture.c: Avoid
 BUG_ON for register failure"

Hi!

This is no big deal either way, and I doubt it is malicious. It will
only hit during development. Returning error is more in line with
linux style.

I'd suggest keeping it.

Best regards,
								Pavel

ci/vpfe_capture.c
> index f9f7dd17c57c..bcedaf4523e0 100644
> --- a/drivers/media/platform/davinci/vpfe_capture.c
> +++ b/drivers/media/platform/davinci/vpfe_capture.c
> @@ -168,22 +168,21 @@ int vpfe_register_ccdc_device(const struct ccdc_hw_device *dev)
>  	int ret = 0;
>  	printk(KERN_NOTICE "vpfe_register_ccdc_device: %s\n", dev->name);
>  
> -	if (!dev->hw_ops.open ||
> -	    !dev->hw_ops.enable ||
> -	    !dev->hw_ops.set_hw_if_params ||
> -	    !dev->hw_ops.configure ||
> -	    !dev->hw_ops.set_buftype ||
> -	    !dev->hw_ops.get_buftype ||
> -	    !dev->hw_ops.enum_pix ||
> -	    !dev->hw_ops.set_frame_format ||
> -	    !dev->hw_ops.get_frame_format ||
> -	    !dev->hw_ops.get_pixel_format ||
> -	    !dev->hw_ops.set_pixel_format ||
> -	    !dev->hw_ops.set_image_window ||
> -	    !dev->hw_ops.get_image_window ||
> -	    !dev->hw_ops.get_line_length ||
> -	    !dev->hw_ops.getfid)
> -		return -EINVAL;
> +	BUG_ON(!dev->hw_ops.open);
> +	BUG_ON(!dev->hw_ops.enable);
> +	BUG_ON(!dev->hw_ops.set_hw_if_params);
> +	BUG_ON(!dev->hw_ops.configure);
> +	BUG_ON(!dev->hw_ops.set_buftype);
> +	BUG_ON(!dev->hw_ops.get_buftype);
> +	BUG_ON(!dev->hw_ops.enum_pix);
> +	BUG_ON(!dev->hw_ops.set_frame_format);
> +	BUG_ON(!dev->hw_ops.get_frame_format);
> +	BUG_ON(!dev->hw_ops.get_pixel_format);
> +	BUG_ON(!dev->hw_ops.set_pixel_format);
> +	BUG_ON(!dev->hw_ops.set_image_window);
> +	BUG_ON(!dev->hw_ops.get_image_window);
> +	BUG_ON(!dev->hw_ops.get_line_length);
> +	BUG_ON(!dev->hw_ops.getfid);
>  
>  	mutex_lock(&ccdc_lock);
>  	if (!ccdc_cfg) {

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)