linux-kernel - Re: [PATCH 057/190] Revert "media: saa7146: Avoid using BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210429201738.GG31692@amd>
Date:   Thu, 29 Apr 2021 22:17:38 +0200
From:   Pavel Machek <pavel@....cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Aditya Pakki <pakki001@....edu>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Subject: Re: [PATCH 057/190] Revert "media: saa7146: Avoid using BUG_ON as an
 assertion"

Hi!

I doubt this is malicious, and BUG()s are ugly. I'd suggest keeping
this.

Best regards,
								Pavel


> diff --git a/drivers/media/common/saa7146/saa7146_video.c b/drivers/media/common/saa7146/saa7146_video.c
> index 7b8795eca589..d9d7d82ca451 100644
> --- a/drivers/media/common/saa7146/saa7146_video.c
> +++ b/drivers/media/common/saa7146/saa7146_video.c
> @@ -345,8 +345,7 @@ static int video_begin(struct saa7146_fh *fh)
>  
>  	fmt = saa7146_format_by_fourcc(dev, vv->video_fmt.pixelformat);
>  	/* we need to have a valid format set here */
> -	if (!fmt)
> -		return -EINVAL;
> +	BUG_ON(NULL == fmt);
>  
>  	if (0 != (fmt->flags & FORMAT_IS_PLANAR)) {
>  		resource = RESOURCE_DMA1_HPS|RESOURCE_DMA2_CLP|RESOURCE_DMA3_BRS;
> @@ -399,8 +398,7 @@ static int video_end(struct saa7146_fh *fh, struct file *file)
>  
>  	fmt = saa7146_format_by_fourcc(dev, vv->video_fmt.pixelformat);
>  	/* we need to have a valid format set here */
> -	if (!fmt)
> -		return -EINVAL;
> +	BUG_ON(NULL == fmt);
>  
>  	if (0 != (fmt->flags & FORMAT_IS_PLANAR)) {
>  		resource = RESOURCE_DMA1_HPS|RESOURCE_DMA2_CLP|RESOURCE_DMA3_BRS;

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)