linux-kernel - Re: [PATCH 16/29] mm: add pte_map_lock() and pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 1 May 2021 07:45:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Michel Lespinasse <michel@...pinasse.org>,
        Linux-MM <linux-mm@...ck.org>,
        Linux-Kernel <linux-kernel@...r.kernel.org>
Cc:     kbuild-all@...ts.01.org, Laurent Dufour <ldufour@...ux.ibm.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Michal Hocko <mhocko@...e.com>,
        Matthew Wilcox <willy@...radead.org>,
        Rik van Riel <riel@...riel.com>,
        Paul McKenney <paulmck@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Suren Baghdasaryan <surenb@...gle.com>
Subject: Re: [PATCH 16/29] mm: add pte_map_lock() and pte_spinlock()

Hi Michel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/x86/mm]
[also build test ERROR on arm64/for-next/core v5.12]
[cannot apply to hnaz-linux-mm/master linus/master next-20210430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Michel-Lespinasse/Speculative-page-faults-anon-vmas-only/20210501-035602
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a500fc918f7b8dc3dff2e6c74f3e73e856c18248
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/284898f9c11d755d2b231794fc7529d562f8e918
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michel-Lespinasse/Speculative-page-faults-anon-vmas-only/20210501-035602
        git checkout 284898f9c11d755d2b231794fc7529d562f8e918
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/mm.h:33,
                    from arch/arm/kernel/asm-offsets.c:12:
   include/linux/mm.h: In function 'pte_map_lock':
>> include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
      79 |  ((pte_t *)kmap_atomic(pmd_page(*(dir))) +  \
         |            ^~~~~~~~~~~
   include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
    2205 |  pte_t *__pte = pte_offset_map(pmd, address); \
         |                 ^~~~~~~~~~~~~~
   include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
    3174 |  vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
         |             ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from include/linux/mm.h:33,
                    from arch/arm/kernel/asm-offsets.c:12:
   include/linux/mm.h: In function 'pte_map_lock':
>> include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
      79 |  ((pte_t *)kmap_atomic(pmd_page(*(dir))) +  \
         |            ^~~~~~~~~~~
   include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
    2205 |  pte_t *__pte = pte_offset_map(pmd, address); \
         |                 ^~~~~~~~~~~~~~
   include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
    3174 |  vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
         |             ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:116: arch/arm/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1233: prepare0] Error 2
   make[1]: Target 'modules_prepare' not remade because of errors.
   make: *** [Makefile:215: __sub-make] Error 2
   make: Target 'modules_prepare' not remade because of errors.
--
   In file included from include/linux/mm.h:33,
                    from arch/arm/kernel/asm-offsets.c:12:
   include/linux/mm.h: In function 'pte_map_lock':
>> include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
      79 |  ((pte_t *)kmap_atomic(pmd_page(*(dir))) +  \
         |            ^~~~~~~~~~~
   include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map'
    2205 |  pte_t *__pte = pte_offset_map(pmd, address); \
         |                 ^~~~~~~~~~~~~~
   include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock'
    3174 |  vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
         |             ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:116: arch/arm/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1233: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:215: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +79 include/linux/pgtable.h

974b9b2c68f3d3 Mike Rapoport 2020-06-08  76  
974b9b2c68f3d3 Mike Rapoport 2020-06-08  77  #if defined(CONFIG_HIGHPTE)
974b9b2c68f3d3 Mike Rapoport 2020-06-08  78  #define pte_offset_map(dir, address)				\
974b9b2c68f3d3 Mike Rapoport 2020-06-08 @79  	((pte_t *)kmap_atomic(pmd_page(*(dir))) +		\
974b9b2c68f3d3 Mike Rapoport 2020-06-08  80  	 pte_index((address)))
974b9b2c68f3d3 Mike Rapoport 2020-06-08  81  #define pte_unmap(pte) kunmap_atomic((pte))
974b9b2c68f3d3 Mike Rapoport 2020-06-08  82  #else
974b9b2c68f3d3 Mike Rapoport 2020-06-08  83  #define pte_offset_map(dir, address)	pte_offset_kernel((dir), (address))
974b9b2c68f3d3 Mike Rapoport 2020-06-08  84  #define pte_unmap(pte) ((void)(pte))	/* NOP */
974b9b2c68f3d3 Mike Rapoport 2020-06-08  85  #endif
974b9b2c68f3d3 Mike Rapoport 2020-06-08  86  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (54366 bytes)