linux-kernel - Re: [PATCH] clk: zynqmp: fix compile testing without ZYNQMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 19:17:14 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michal Simek <michal.simek@...inx.com>,
        Punit Agrawal <punit1.agrawal@...hiba.co.jp>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Arnd Bergmann <arnd@...db.de>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jolly Shah <jolly.shah@...inx.com>,
        Quanyang Wang <quanyang.wang@...driver.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: zynqmp: fix compile testing without ZYNQMP_FIRMWARE

Quoting Punit Agrawal (2021-04-22 23:37:25)
> Michal Simek <michal.simek@...inx.com> writes:
> >
> >
> >>>  
> >>>     rate =  parent_rate * fbdiv;
> >>>     if (zynqmp_pll_get_mode(hw) == PLL_MODE_FRAC) {
> >> 
> >> The changes make sense in that the functions error out sensibly when the
> >> zynqmp firmware driver is not enabled.
> >> 
> >> Acked-by: Punit Agrawal <punit1.agrawal@...hiba.co.jp>
> >
> > I think code should be checked that these error values are handled how
> > they should be handled.
> 
> I only looked at it from the point of view of getting rid of the
> warnings - based on the commit log, Arnd's patch is only taking care of
> the compiler warnings when the driver is built with
> CONFIG_COMPILE_TEST=y and likely CONFIG_ZYNQMP_FIRMWARE=n.

The subject line basically says this.

> 
> In practice, the code should not be hit at runtime due to the dependency
> on the firmware driver. Even then, a better fix would indeed be taking
> the returned values at call sites into account.

Still needs to be fixed. If a better patch is sent I would apply it, but
if that isn't going to happen I'll apply this one.