linux-kernel - Re: [PATCH net-next v1 1/1] net: selftest: provide option to disable generic selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Apr 2021 17:41:53 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Fugang Duan <fugang.duan@....com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        kernel@...gutronix.de, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-imx@....com, Fabio Estevam <festevam@...il.com>,
        David Jander <david@...tonic.nl>,
        Russell King <linux@...linux.org.uk>,
        Philippe Schenker <philippe.schenker@...adex.com>
Subject: Re: [PATCH net-next v1 1/1] net: selftest: provide option to disable
 generic selftests

On Fri, Apr 30, 2021 at 08:13:12AM -0700, Randy Dunlap wrote:
> On 4/30/21 2:53 AM, Oleksij Rempel wrote:
> > Some systems may need to disable selftests to reduce kernel size or for
> > some policy reasons. This patch provide option to disable generic selftests.
> > 
> > Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Fixes: 3e1e58d64c3d ("net: add generic selftest support")
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >  net/Kconfig | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/net/Kconfig b/net/Kconfig
> > index f5ee7c65e6b4..dac98c73fcd8 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -431,7 +431,12 @@ config SOCK_VALIDATE_XMIT
> >  
> >  config NET_SELFTESTS
> >  	def_tristate PHYLIB
> > +	prompt "Support for generic selftests"
> >  	depends on PHYLIB && INET
> > +	help
> > +	  These selftests are build automatically if any driver with generic
> 
> 	                      built
> 
> > +	  selftests support is enabled. This option can be used to disable
> > +	  selftests to reduce kernel size.
> >  
> >  config NET_SOCK_MSG
> >  	bool
> > 
> 
> Thanks for the patch/option. But I think it should just default to n,
> not PHYLIB.

It should be enabled by default for every device supporting this kind of
selftests. This tests extend functionality of cable tests, which are not
optional. Disabling it by default makes even less sense, at least for
me.

It depends on PHYLIB, if PHYLIB is build as module, this
this part should be build as module too. And since Geert asking to make
it optional, I provided this patch.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |