linux-kernel - Re: [PATCH] scsi: target: configfs: Remove redundant assignment to ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fad772f-51da-6415-76a4-ed248736ced5@gmail.com>
Date:   Fri, 30 Apr 2021 17:43:13 +0200
From:   Bodo Stroesser <bostroesser@...il.com>
To:     michael.christie@...cle.com,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: target: configfs: Remove redundant assignment to
 ret

On 30.04.21 17:40, michael.christie@...cle.com wrote:
> On 4/30/21 9:29 AM, Bodo Stroesser wrote:
>> BTW: why is "initiator_sid" input handled as string?
>> core_scsi3_alloc_aptpl_registration later calls get_unaligned_be64 for
>> that string. I don't think this makes sense.
> 
> It's broken.
> 
> Remember the isid patches that you reviewed of mine trying to fix the
> isid code in target_core_transport.c? I can't remember all the details but
> I think it was that the aptpl code thinks the buffer is in the format that
> sess_get_initiator_sid uses and is trying to do something similar as
> target_core_transport.c.
> 
> I can't find the version of the patches you had looked at. This was the first
> version of the patch:
> 
> https://patchwork.kernel.org/project/target-devel/patch/1531696591-8558-3-git-send-email-mchristi@redhat.com/
> 

Ahh, yes. I remember. Thank you.