linux-kernel - Re: [PATCH] nvme: fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210430175723.GA664165@bjorn-Precision-5520>
Date:   Fri, 30 Apr 2021 12:57:23 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Prike Liang <Prike.Liang@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rajat Jain <rajatja@...gle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: fix unused variable warning

On Wed, Apr 21, 2021 at 04:04:20PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The function was introduced with a variable that is never referenced:
> 
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:25: warning: unused variable 'rdev' [-Wunused-variable]
> 
> Fixes: 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")

I guess this refers to https://lore.kernel.org/linux-nvme/1618458725-17164-1-git-send-email-Prike.Liang@amd.com/

But I don't know what the SHA1 means; I can't find it in linux-next or
my tree.

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/pci/quirks.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 2e24dced699a..c86ede081534 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -309,8 +309,6 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD,	PCI_DEVICE_ID_AMD_8151_0,	quirk_nopci
>  
>  static void quirk_amd_nvme_fixup(struct pci_dev *dev)
>  {
> -	struct pci_dev *rdev;
> -
>  	dev->dev_flags |= PCI_DEV_FLAGS_AMD_NVME_SIMPLE_SUSPEND;
>  	pci_info(dev, "AMD simple suspend opt enabled\n");
>  
> -- 
> 2.29.2
>