linux-kernel - Re: [PATCH] nvme: fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIBZZ7EvA1CUk0vb@client-192-168-1-100.lan>
Date:   Wed, 21 Apr 2021 18:57:11 +0200
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Prike Liang <Prike.Liang@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Rajat Jain <rajatja@...gle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bixuan Cui <cuibixuan@...wei.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: fix unused variable warning

[+cc Bixuan]

Hi Arnd,

> The function was introduced with a variable that is never referenced:
> 
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:25: warning: unused variable 'rdev' [-Wunused-variable]
> 
> Fixes: 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
[...]

A simialr patch was sent recently, as per:

  https://lore.kernel.org/linux-pci/20210417114258.23640-1-cuibixuan@huawei.com/

Other than that,

Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>

Krzysztof