[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YJBmkNky4QfFhPD1@zeniv-ca.linux.org.uk>
Date: Mon, 3 May 2021 21:09:36 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
"J. Bruce Fields" <bfields@...hat.com>,
Kefeng Wang <wangkefeng.wang@...wei.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-nfs@...r.kernel.org,
Linux FS Devel <linux-fsdevel@...r.kernel.org>,
"J. Bruce Fields" <bfields@...ldses.org>,
Chuck Lever <chuck.lever@...cle.com>,
Andy Shevchenko <andy@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v1 10/12] nfsd: Avoid non-flexible API in seq_quote_mem()
On Mon, May 03, 2021 at 11:56:41PM +0300, Andy Shevchenko wrote:
> On Mon, May 3, 2021 at 11:54 PM Al Viro <viro@...iv.linux.org.uk> wrote:
> >
> > On Mon, May 03, 2021 at 11:49:05PM +0300, Andy Shevchenko wrote:
> > > string_escape_mem_ascii() followed by seq_escape_mem_ascii() is completely
> > > non-flexible and shouldn't be exist from day 1.
> > >
> > > Replace it with properly called string_escape_mem().
> >
> > NAKed-by: Al Viro <viro@...iv.linux.org.uk>
> >
> > Reason: use of seq_get_buf(). Which should have been static inline in
> > fs/seq_file.c, to start with.
>
> I see.
>
> > Again, any new uses of seq_get_buf()/seq_commit() are grounds for automatic
> > NAK. These interfaces *will* be withdrawn.
>
> You meant that this is no way to get rid of this guy?
> Any suggestions how to replace that API with a newer one?
seq_escape_mem(), perhaps?
Powered by blists - more mailing lists