linux-kernel - Re: [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left empty by ODM_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210503074217.GA1557@agape.jhs>
Date:   Mon, 3 May 2021 09:42:18 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left
 empty by ODM_RT_TRACE deletion

On Mon, May 03, 2021 at 10:27:11AM +0300, Dan Carpenter wrote:
> On Fri, Apr 30, 2021 at 04:56:24PM +0200, Fabio Aiuto wrote:
> > @@ -1533,13 +1529,10 @@ static void phy_IQCalibrate_8723B(
> >  				result[t][6] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> >  				result[t][7] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> >  				break;
> > -			} else {
> >  			}
> >  		}
> >  
> >  /* Allen end */
> 
> This comment doesn't mean anything.  It feels like it was supposed to
> go with the code that you deleted so it should have been deleted as part
> of deleting the empty block.  But it's fine to me if you delete it in
> a later patch.

Hi Dan,

ok I will.

> 
> > -		if (0x00 == PathBOK) {
> > -		}
> >  	}
> >  
> >  	/* Back to BB mode, load original value */
> 
> regards,
> dan carpenter
> 

thank you,

fabio