linux-kernel - Re: [PATCH v3 16/43] staging: rtl8723bs: remove unused ASSERT macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210503074306.GB1557@agape.jhs>
Date:   Mon, 3 May 2021 09:43:07 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 16/43] staging: rtl8723bs: remove unused ASSERT macro

On Mon, May 03, 2021 at 10:31:32AM +0300, Dan Carpenter wrote:
> On Fri, Apr 30, 2021 at 04:56:38PM +0200, Fabio Aiuto wrote:
> > remove unused do nothing ASSERT macro definition.
> > 
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>
> > ---
> >  drivers/staging/rtl8723bs/hal/odm_debug.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h
> > index 8ae9948fb0c6..78b9b4548dcb 100644
> > --- a/drivers/staging/rtl8723bs/hal/odm_debug.h
> > +++ b/drivers/staging/rtl8723bs/hal/odm_debug.h
> > @@ -92,7 +92,6 @@
> >  	#define RT_DISP(dbgtype, dbgflag, printstr)
> >  
> >  #ifndef ASSERT
> > -	#define ASSERT(expr)
> >  #endif
> 
> Presumably you're going to delete the #ifndef/endif in the next patch
> but it should have been done in one step here.  (No need to resend.  For
> future reference only).
> 
> regards,
> dan carpenter
> 

ok, thank you,

fabio