linux-kernel - Re: [PATCH] video: fbdev: imxfb: Fix an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210507082033.ihp2ozulam72wezw@pengutronix.de>
Date:   Fri, 7 May 2021 10:20:33 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     linux-fbdev@...r.kernel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel-janitors@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        j.beisert@...gutronix.de, linux-imx@....com, kernel@...gutronix.de,
        festevam@...il.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] video: fbdev: imxfb: Fix an error message

Hello Christophe,

[dropping krzysztof.h1@...zta.fm from recipents, the address doesn't
seem to exist]

On Fri, May 07, 2021 at 09:11:19AM +0200, Christophe JAILLET wrote:
> Le 07/05/2021 à 07:05, Uwe Kleine-König a écrit :
> > On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote:
> > > 'ret' is known to be 0 here.
> > > No error code is available, so just remove it from the error message.
> > > 
> > > Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of direct pointer deref")
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > > ---
> > >   drivers/video/fbdev/imxfb.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
> > > index 7f8debd2da06..ad598257ab38 100644
> > > --- a/drivers/video/fbdev/imxfb.c
> > > +++ b/drivers/video/fbdev/imxfb.c
> > > @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev)
> > >   	info->screen_buffer = dma_alloc_wc(&pdev->dev, fbi->map_size,
> > >   					   &fbi->map_dma, GFP_KERNEL);
> > >   	if (!info->screen_buffer) {
> > > -		dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret);
> > > +		dev_err(&pdev->dev, "Failed to allocate video RAM\n");
> > >   		ret = -ENOMEM;
> > >   		goto failed_map;
> > >   	}
> > 
> > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > 
> > Are you using this driver, or did you find that problem using some
> > static checker?
> 
> No, I'm not using this driver AFAIK.

OK, thanks. (We're working on a DRM driver for this hardware. So you
could have been an interested tester.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)