linux-kernel - Re: [PATCH] video: fbdev: imxfb: Fix an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJVsGn4+rbh0+b+I@phenom.ffwll.local>
Date:   Fri, 7 May 2021 18:34:34 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-fbdev@...r.kernel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel-janitors@...r.kernel.org,
        krzysztof.h1@...zta.fm, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, j.beisert@...gutronix.de,
        linux-imx@....com, kernel@...gutronix.de,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] video: fbdev: imxfb: Fix an error message

On Fri, May 07, 2021 at 07:05:03AM +0200, Uwe Kleine-König wrote:
> Hello Christophe,
> 
> On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote:
> > 'ret' is known to be 0 here.
> > No error code is available, so just remove it from the error message.
> > 
> > Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of direct pointer deref")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > ---
> >  drivers/video/fbdev/imxfb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
> > index 7f8debd2da06..ad598257ab38 100644
> > --- a/drivers/video/fbdev/imxfb.c
> > +++ b/drivers/video/fbdev/imxfb.c
> > @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev)
> >  	info->screen_buffer = dma_alloc_wc(&pdev->dev, fbi->map_size,
> >  					   &fbi->map_dma, GFP_KERNEL);
> >  	if (!info->screen_buffer) {
> > -		dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret);
> > +		dev_err(&pdev->dev, "Failed to allocate video RAM\n");
> >  		ret = -ENOMEM;
> >  		goto failed_map;
> >  	}
> 
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks for patch& review, queued for 5.14 in drm-misc-next.
-Daniel

> 
> Are you using this driver, or did you find that problem using some
> static checker?
> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch